fix stack-trace when calling done with non-error (#6016)

* fix stack-trace when calling `done` * create Error in `fail` if not passed
jestjs · Apr 18, 2018 · a36a69c · a36a69c
1 parent fb356ac
commit a36a69c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/integration-tests/__tests__/__snapshots__/failures.test.js.snap b/integration-tests/__tests__/__snapshots__/failures.test.js.snap
@@ -240,17 +240,15 @@ exports[`not throwing Error objects 5`] = `
       ],
     }
 
-      33 | });
       34 | 
-    > 35 | test('done(non-error)', done => {
-         | ^
-      36 |   done(deepObject);
+      35 | test('done(non-error)', done => {
+    > 36 |   done(deepObject);
+         |   ^
       37 | });
       38 | 
       
-      
-      at packages/jest-jasmine2/build/jasmine/Spec.js:79:20
-      at __tests__/during_tests.test.js:35:1
+      at packages/jest-jasmine2/build/jasmine/Env.js:542:34
+      at __tests__/during_tests.test.js:36:3
 
 "
 `;

diff --git a/packages/jest-jasmine2/src/jasmine/Env.js b/packages/jest-jasmine2/src/jasmine/Env.js
@@ -561,7 +561,7 @@ export default function(j$) {
         expected: '',
         actual: '',
         message,
-        error: isError ? error : null,
+        error: isError ? error : new Error(message),
       });
     };
   }