-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing deprecations and updating POM #17
Conversation
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
@@ -40,16 +40,17 @@ | |||
<properties> | |||
<jenkins.version>2.60</jenkins.version> | |||
<java.level>8</java.level> | |||
<no-test-jar>false</no-test-jar> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgotten in #15.
import org.kohsuke.stapler.DataBoundSetter; | ||
|
||
/** | ||
* A step which uses some kind of {@link SCM}. | ||
*/ | ||
public abstract class SCMStep extends AbstractStepImpl implements Serializable { | ||
public abstract class SCMStep extends Step { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Serializable
seems to be left over from jenkinsci/pipeline-plugin@f6d57d3 when the StepExecution
was an inner class.
@@ -127,16 +132,14 @@ public final void checkout(Run<?,?> run, FilePath workspace, TaskListener listen | |||
l.onCheckout(run, scm, workspace, listener, changelogFile, pollingBaseline); | |||
} | |||
scm.postCheckout(run, launcher, workspace, listener); | |||
// TODO should we call buildEnvVars and return the result? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obsolete as of #16
protected abstract @Nonnull SCM createSCM(); | ||
|
||
public static final class StepExecutionImpl extends AbstractSynchronousNonBlockingStepExecution<Map<String,String>> { | ||
public static final class StepExecutionImpl extends SynchronousNonBlockingStepExecution<Map<String,String>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be the first step in fixing JENKINS-44838.
@reviewbybees