-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on obsolete workflow-scm-step tests artifact #88
Conversation
@@ -69,7 +69,7 @@ | |||
<no-test-jar>false</no-test-jar> | |||
<useBeta>true</useBeta> | |||
<git-plugin.version>3.7.0</git-plugin.version> | |||
<workflow-scm-step-plugin.version>2.6</workflow-scm-step-plugin.version> | |||
<workflow-scm-step-plugin.version>2.7</workflow-scm-step-plugin.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, there is no need to update this to fix the issue, but we might as well bump to the latest version while we're here so we can catch these kinds of issues before the PCT.
awesome~~~ thanks for looking into this so quickly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Thanks @dwnusbaum .
Ping @jenkinsci/java11-support for more eyes. |
@batmat Do you need this urgently? I am happy to merge+release now, but am not aware of a pressing need for it so it is on my TODO list. |
Afaik we had nothing, at least yet, tracking this. Should likely add it in https://docs.google.com/document/d/1oluVrNVpQhXCIwW9CYVm09Y1vPc3H77d3q92LrzcpDw/edit?usp=drivesdk for completeness. Thanks! |
Went ahead and released 3.1 since I had some time. |
Fixes PCT failures when running against workflow-scm-step 2.7. As of jenkinsci/workflow-scm-step-plugin#17, the workflow-scm-steps tests artifact is no longer produced, because the useful classes it had were moved to scm-api in jenkinsci/workflow-scm-step-plugin#15 (landed originally in workflow-scm-step-2.5, i.e. the tests artifact has been obsolete for a long time).
CC @halkeye