Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on obsolete workflow-scm-step tests artifact #88

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

dwnusbaum
Copy link
Member

Fixes PCT failures when running against workflow-scm-step 2.7. As of jenkinsci/workflow-scm-step-plugin#17, the workflow-scm-steps tests artifact is no longer produced, because the useful classes it had were moved to scm-api in jenkinsci/workflow-scm-step-plugin#15 (landed originally in workflow-scm-step-2.5, i.e. the tests artifact has been obsolete for a long time).

CC @halkeye

@@ -69,7 +69,7 @@
<no-test-jar>false</no-test-jar>
<useBeta>true</useBeta>
<git-plugin.version>3.7.0</git-plugin.version>
<workflow-scm-step-plugin.version>2.6</workflow-scm-step-plugin.version>
<workflow-scm-step-plugin.version>2.7</workflow-scm-step-plugin.version>
Copy link
Member Author

@dwnusbaum dwnusbaum Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, there is no need to update this to fix the issue, but we might as well bump to the latest version while we're here so we can catch these kinds of issues before the PCT.

@halkeye
Copy link
Member

halkeye commented Jan 14, 2019

awesome~~~

thanks for looking into this so quickly

Copy link

@kshultzCB kshultzCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

Thanks @dwnusbaum .

@batmat
Copy link
Member

batmat commented Jan 16, 2019

Ping @jenkinsci/java11-support for more eyes.

@dwnusbaum
Copy link
Member Author

@batmat Do you need this urgently? I am happy to merge+release now, but am not aware of a pressing need for it so it is on my TODO list.

@dwnusbaum dwnusbaum merged commit cfe5d19 into jenkinsci:master Jan 16, 2019
@dwnusbaum dwnusbaum deleted the pct-cleanup branch January 16, 2019 20:16
@batmat
Copy link
Member

batmat commented Jan 16, 2019

Afaik we had nothing, at least yet, tracking this.
I just guess that the sooner, without urgency, the better so we avoid potential time spent running PCT and failing on this.

Should likely add it in https://docs.google.com/document/d/1oluVrNVpQhXCIwW9CYVm09Y1vPc3H77d3q92LrzcpDw/edit?usp=drivesdk for completeness.

Thanks!

@dwnusbaum
Copy link
Member Author

Went ahead and released 3.1 since I had some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants