Initial Windows support for maven docker image #6
Conversation
|
@slide does this require a Windows environment? Or can this be plugged into the |
|
To build windows containers, you need a windows system. We're in kind of a chicken and egg problem as there are no Windows agents that have docker installed to build stuff like this yet, but we need these type of images to start some of that... |
There was a problem hiding this comment.
So not yet in maven/Makefile, because it could not be, hmm. So we need to amend the Windows agent VM templates to include a Docker installation, if that is even possible?
Seems like DockerHub automated builds still do not support Windows, so we could not switch to that.
|
@jglick, correct, you have to have a Windows system to build a Windows docker image. I think we can add docker to the Windows VM templates, but I will have to look into it. AppVeyor does support Docker builds, however, it is using Windows Server 2016 instead of Windows Server 2019 (which has better container support). |
|
Well in the short term I guess we would just manually publish images built from this work. There are not that many changes anyway. |
|
Agreed, we just need someone with Windows platform(s) (2016 and 2019 would be the best if possible) who can build the images and then publish them. |
|
I think I can fairly easily enable Windows docker nodes on ci.jenkins.io and trusted.ci. I am requesting access to ci.jenkins.io in order to enable it. |
|
I have successfully setup a Windows docker agent on ci.jenkins.io, so we should be able to build these images somewhat soon. I will determine how it will work best to fit into the current Makefile like framework (won't be in Makefile, but I'll try and maintain a similar idea). |
|
We have the capability to build these on both ci.j.io and trusted now. I need to upgrade the containers to use the "official" maven images now. |
slide
changed the title
|
@rtyler This is ready for review if you have some time. |
|
Close and resubmit because I messed something up |
|
⇒ #12 |
fix: correct JNLP path and installations
This depends on several other docker images being pushed to docker hub. Just wanted to get it in here to get some feedback started.