Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Add Windows image build scripts #94

Merged
merged 19 commits into from
Oct 10, 2019
Merged

Add Windows image build scripts #94

merged 19 commits into from
Oct 10, 2019

Conversation

slide
Copy link
Member

@slide slide commented Aug 21, 2019

The agent label may change for Windows, but is good for now.

Adds Windows build of the docker image.
The docker label for windows may change to just "docker", but this will work for now.
Jenkinsfile Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
slide and others added 2 commits August 23, 2019 10:05
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
Jenkinsfile Outdated Show resolved Hide resolved
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
Copy link

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some work I will be introducing to change the naming schemes but this lgtm

parallel {
stage('Windows') {
agent {
label 'windock'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkinsfile Outdated
steps {
deleteDir()
checkout scm
powershell '& ./make.ps1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in #91 FTR

@slide
Copy link
Member Author

slide commented Aug 23, 2019

Does the timeout option start when the job is actually assigned to a node, or from when the job is put into the queue?

@jglick
Copy link
Member

jglick commented Aug 23, 2019

Does the timeout option start when…

This kind of question is why I avoid Declarative. :-/

Jenkinsfile Outdated Show resolved Hide resolved
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
@oleg-nenashev
Copy link
Member

Is it ready to go @slide @olblak

@slide
Copy link
Member Author

slide commented Sep 18, 2019

Looks like I need to extend the timeout since it takes some time for the windows vm to spin up. I'll update the PR in a bit.

Take into account Windows VM spinup time
@olblak
Copy link
Member

olblak commented Sep 19, 2019

I don't have any permission on this repository but I am strongly in favor of this 🎆

@olblak
Copy link
Member

olblak commented Sep 19, 2019

At least when the job succeed :)

@slide
Copy link
Member Author

slide commented Sep 19, 2019

Not sure why, but this is the error that is occurring on the Windows machine:

[2019-09-19T15:29:49.089Z] using credential github-access-token
[2019-09-19T15:29:49.180Z] Fetching changes from the remote Git repository
[2019-09-19T15:29:49.193Z] Fetching without tags
[2019-09-19T15:29:49.415Z] Merging remotes/origin/master commit 4506b069a2c9d96667e14e8be3ecb718ed51b29d into PR head commit 10c50e14d3fd7faa8effa4ffad49a8590d06b3a5

Cannot checkout from unborn branch

@slide slide closed this Oct 8, 2019
@slide slide reopened this Oct 8, 2019
Remove deleteDir, fails on Windows for some reason.
Get setup for publishing.
@slide slide merged commit a187508 into jenkinsci:master Oct 10, 2019
@oleg-nenashev oleg-nenashev changed the title Add windows build Add Windows image build scripts Dec 25, 2019
lemeurherve pushed a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants