-
-
Notifications
You must be signed in to change notification settings - Fork 528
Conversation
Adds Windows build of the docker image.
The docker label for windows may change to just "docker", but this will work for now.
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some work I will be introducing to change the naming schemes but this lgtm
parallel { | ||
stage('Windows') { | ||
agent { | ||
label 'windock' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using jenkinsci/docker-inbound-agents#6 IIUC
Jenkinsfile
Outdated
steps { | ||
deleteDir() | ||
checkout scm | ||
powershell '& ./make.ps1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in #91 FTR
Does the |
This kind of question is why I avoid Declarative. :-/ |
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
Looks like I need to extend the timeout since it takes some time for the windows vm to spin up. I'll update the PR in a bit. |
Take into account Windows VM spinup time
I don't have any permission on this repository but I am strongly in favor of this 🎆 |
At least when the job succeed :) |
Not sure why, but this is the error that is occurring on the Windows machine:
|
Remove deleteDir, fails on Windows for some reason. Get setup for publishing.
clean after apt install
The agent label may change for Windows, but is good for now.