Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linux tests) remove deprecated jdk17-only check #317

Merged
merged 1 commit into from
Nov 12, 2022
Merged

chore(linux tests) remove deprecated jdk17-only check #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions tests/tests.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ ARCH=${ARCH:-x86_64}
@test "[${SUT_IMAGE}] use build args correctly" {
cd "${BATS_TEST_DIRNAME}"/.. || false

local TEST_VERSION="3.36"
local TEST_VERSION="3025.vf64a_a_3da_6b_55" # Older version, must work with JDK11 and JDK17 and should contain https://github.com/jenkinsci/remoting/pull/532
local TEST_USER="test-user"
local TEST_GROUP="test-group"
local TEST_UID=2000
Expand All @@ -102,12 +102,8 @@ docker buildx bake \

is_agent_container_running "${cid}"

# TODO https://github.com/jenkinsci/remoting/pull/481
# Current line is: 'A terminally deprecated method in java.lang.System has been called'
if [[ $IMAGE != *"17"* ]]; then
run docker exec "${cid}" sh -c "java -cp /usr/share/jenkins/agent.jar hudson.remoting.jnlp.Main -version"
assert_line --index 0 "${TEST_VERSION}"
fi
run docker exec "${cid}" sh -c "java -cp /usr/share/jenkins/agent.jar hudson.remoting.jnlp.Main -version"
assert_line --index 0 "${TEST_VERSION}"

run docker exec "${cid}" sh -c "id -u -n ${TEST_USER}"
assert_line --index 0 "${TEST_USER}"
Expand Down