Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linux tests) remove deprecated jdk17-only check #317

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

dduportal
Copy link
Contributor

Fix #304

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dduportal dduportal requested a review from a team as a code owner November 12, 2022 09:45
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removing the check rather than the if guard that skipped this part of the test on Java 17

@dduportal dduportal requested a review from timja November 12, 2022 11:50
@dduportal
Copy link
Contributor Author

This is removing the check rather than the if guard that skipped this part of the test on Java 17

My bad, I misunderstood the initial intent. Should be fixed now.

@dduportal
Copy link
Contributor Author

Ah ah nice one: the use build args correctly test, which uses another version of the remoting than the specified one, fails the associated check: it uses a remoting version pre-dating the fix jenkinsci/remoting#532 :D

Gotta update the "old remoting" version being checked in this PR.

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal merged commit 6cd8096 into jenkinsci:master Nov 12, 2022
@dduportal dduportal deleted the chore/tests/gh-304 branch November 12, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Harness: remove JDK17 WebStart specific test
3 participants