-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding capability to deploy using Docker. #1525
Open
Harshraj9812
wants to merge
4
commits into
jagrosh:master
Choose a base branch
from
Harshraj9812:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
name: Build MusicBot Docker Image | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
musicbot_version: | ||
description: 'Jagrosh/MusicBot version (required) Ex-0.3.9' | ||
required: true | ||
default: '0.3.9' | ||
|
||
jobs: | ||
Build-Push-Docker-Image: | ||
runs-on: ubuntu-latest | ||
env: | ||
musicbot_version: ${{ github.event.inputs.musicbot_version }} | ||
|
||
steps: | ||
- name: Checkout Repository | ||
uses: actions/checkout@v3 | ||
|
||
- name: Building Docker Image | ||
run: | | ||
echo ${musicbot_version} | ||
docker build --build-arg MUSICBOT_VERSION=${musicbot_version} -t ${{ secrets.DOCKER_USERNAME }}/jmusicbot:${musicbot_version} . | ||
|
||
- name: Log in to Docker Hub | ||
env: | ||
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} | ||
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} | ||
run: | | ||
echo $DOCKER_PASSWORD | docker login -u $DOCKER_USERNAME --password-stdin | ||
|
||
- name: Pushing Docker Image to Docker Hub | ||
run: docker push ${{ secrets.DOCKER_USERNAME }}/jmusicbot:${musicbot_version} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
FROM amazoncorretto:11-al2023 | ||
|
||
ARG MUSICBOT_VERSION | ||
|
||
WORKDIR / | ||
|
||
RUN pwd | ||
RUN ls -lrt | ||
|
||
ENV TOKEN harsh | ||
|
||
RUN echo "Building MusicBot version: $MUSICBOT_VERSION" | ||
|
||
# Download and rename the JAR file based on the provided version | ||
RUN curl -LJO "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" \ | ||
&& mv "JMusicBot-$MUSICBOT_VERSION.jar" JMusicBot.jar | ||
|
||
# Copying Repo config.txt file to Build | ||
COPY config.txt /config.txt | ||
|
||
# Replace occurrences of ${BOT-TOKEN} with the value of TOKEN in config.txt during runtime | ||
CMD ["sh", "-c", "sed -i 's/${BOT-TOKEN}/${TOKEN}/g' /config.txt && java -Dnogui=true -jar /JMusicBot.jar"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
version: "3" | ||
services: | ||
discord-bot: | ||
container_name: Discord-Hr-Music-bot | ||
restart: unless-stopped | ||
# Modify Version as per input[0.3.9] | ||
image: [DOCKER HUB USER]/jmusic:[version] | ||
labels: | ||
# This is for Watchtower to Ignore Updating this Image. | ||
- "com.centurylinklabs.watchtower.enable=false" | ||
environment: | ||
# Add your Bot TOken below | ||
- TOKEN=[BOT TOKEN] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be preferred to use the build artifacts from the previous job instead of fetching the release file like this. The files attached on a release are not necessarily the same as builds from source code.
Tip: with curl the mv step is also completely unnecessary since you can also save the file as a specified filename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jogerj
Can you please help me with the change required to get the build form Artificats, I found this way more easier and understandable.