-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding capability to deploy using Docker. #1525
base: master
Are you sure you want to change the base?
Conversation
RUN curl -LJO "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" \ | ||
&& mv "JMusicBot-$MUSICBOT_VERSION.jar" JMusicBot.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be preferred to use the build artifacts from the previous job instead of fetching the release file like this. The files attached on a release are not necessarily the same as builds from source code.
Tip: with curl the mv step is also completely unnecessary since you can also save the file as a specified filename
RUN curl -LJO "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" \ | |
&& mv "JMusicBot-$MUSICBOT_VERSION.jar" JMusicBot.jar | |
RUN curl -o JMusicBot.jar -LJ "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jogerj
Can you please help me with the change required to get the build form Artificats, I found this way more easier and understandable.
This pull request...
Description
These changes are to make this awesome bot docker deployment ready for Ease of Deployment.
Things added -
Config Changes needed
Purpose
These changes will add a new capability to this bot to be deployed with Docker, Which will ease the Deployment process without any dependency on OS.
Relevant Issue(s)
No fix for any ongoing issue, This is for additional deployment improvement.