Revert #5482 - ppc64le is not yet supported by delve #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
the
changelog:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5489 +/- ##
==========================================
- Coverage 96.23% 96.20% -0.03%
==========================================
Files 330 330
Lines 16156 16156
==========================================
- Hits 15547 15543 -4
- Misses 435 437 +2
- Partials 174 176 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akagami-harsh
approved these changes
May 26, 2024
varshith257
pushed a commit
to varshith257/jaeger
that referenced
this pull request
Jun 2, 2024
…egertracing#5489) ## Which problem is this PR solving? - `ppc64le` was added in jaegertracing#5482, but even though it has been implemented in delve (go-delve/delve#2104), it has not yet been released as of delve@v1.22.1 - since our PR CI does not build all arch, it was not noticed until the CI on the main branch started failing ## Description of the changes - Add `ppc64le` back to exclusion list ## How was this change tested? - only after merging Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
ppc64lewas added in Enable debug builds for ppc64le #5482, but even though it has been implemented in delve (ppc64le go-delve/delve#2104), it has not yet been released as of delve@v1.22.1Description of the changes
ppc64leback to exclusion listHow was this change tested?