-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable debug builds for ppc64le #5482
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5482 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 331 331
Lines 16155 16155
=======================================
Hits 15432 15432
Misses 548 548
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Yuri Shkuro <github@ysh.us>
## Which problem is this PR solving? - `ppc64le` was added in #5482, but even though it has been implemented in delve (go-delve/delve#2104), it has not yet been released as of delve@v1.22.1 - since our PR CI does not build all arch, it was not noticed until the CI on the main branch started failing ## Description of the changes - Add `ppc64le` back to exclusion list ## How was this change tested? - only after merging Signed-off-by: Yuri Shkuro <github@ysh.us>
…egertracing#5489) ## Which problem is this PR solving? - `ppc64le` was added in jaegertracing#5482, but even though it has been implemented in delve (go-delve/delve#2104), it has not yet been released as of delve@v1.22.1 - since our PR CI does not build all arch, it was not noticed until the CI on the main branch started failing ## Description of the changes - Add `ppc64le` back to exclusion list ## How was this change tested? - only after merging Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Which problem is this PR solving?
Description of the changes
How was this change tested?