[kafka-consumer] Add topic name as a tag to offset manager metrics #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th topic name Resolves jaegertracing#4950 Add tag with topic name to metrics emitted by Kafka consumer offset manager. Signed-off-by: Alex Bublichenko <alexbub@uber.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4951 +/- ##
==========================================
- Coverage 96.45% 96.44% -0.02%
==========================================
Files 304 304
Lines 18045 18049 +4
==========================================
+ Hits 17406 17408 +2
- Misses 506 508 +2
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
approved these changes
Nov 14, 2023
yurishkuro
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #4950
Description of the changes
Add tag with topic name to metrics emitted by Kafka consumer offset manager.
How was this change tested?
Unit tests