Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Consumer offset manager metrics should have a tag with topic name #4950

Closed
abliqo opened this issue Nov 14, 2023 · 1 comment · Fixed by #4951
Closed

[Bug]: Consumer offset manager metrics should have a tag with topic name #4950

abliqo opened this issue Nov 14, 2023 · 1 comment · Fixed by #4951
Labels
bug

Comments

@abliqo
Copy link
Contributor

abliqo commented Nov 14, 2023

What happened?

The recent change #4593 updated the consumer code of the ingester to support ingestion from multiple Kafka topics when sarama consumer is created in custom way with multiple topics. However, the metrics in the offset manager lack the tag with topic name.

Steps to reproduce

  1. Ingest from multiple Kafka topics with sarama consumer created in custom way.
  2. Check the metric with last-committed-offset - it does not have topic tag.

Expected behavior

All consumer offset manager metrics should have a tag with topic name.

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response
@abliqo abliqo added the bug label Nov 14, 2023
@abliqo
Copy link
Contributor Author

abliqo commented Nov 14, 2023

I will fix it.

abliqo added a commit to abliqo/jaeger that referenced this issue Nov 14, 2023
@abliqo
[kafka-consumer] Consumer offset manager metrics should have a tag wi…
b90802a 
…th topic name

Resolves jaegertracing#4950

Add tag with topic name to metrics emitted by Kafka consumer offset manager.

Signed-off-by: Alex Bublichenko <alexbub@uber.com>
@abliqo abliqo mentioned this issue Nov 14, 2023
Merged
yurishkuro pushed a commit that referenced this issue Nov 14, 2023
@abliqo
[kafka-consumer] Add topic name as a tag to offset manager metrics (#…
ef311cf 
…4951)

## Which problem is this PR solving?

Resolves #4950

## Description of the changes

Add tag with topic name to metrics emitted by Kafka consumer offset
manager.

## How was this change tested?
Unit tests

Signed-off-by: Alex Bublichenko <alexbub@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[kafka-consumer] Add topic name as a tag to offset manager metrics abliqo/jaeger
1 participant
@abliqo