Fix bad boundary matches #188
Conversation
1 similar comment
dumb-jump.el
Outdated
|
|
||
| (:type "variable" :supports ("ag" "grep" "rg" "git-grep") :language "elisp" | ||
| :regex "\\\(setq\\b\\s*JJJ\\j" :tests ("(setq test 123)") :not ("setq test-blah 123)")) | ||
| :regex "\\\(setq\\b\\s*JJJ\\j" :tests ("(setq test 123)") |
There was a problem hiding this comment.
Like in the other places, it would be nice with a newline before :tests for readability.
| @@ -125,25 +125,25 @@ or most optimal searcher." | |||
| :type 'string) | |||
|
|
|||
| (defcustom dumb-jump-ag-word-boundary | |||
| "(?![\\w\\?\\*-])" | |||
| "(?![a-zA-Z0-9\\?\\*-])" | |||
There was a problem hiding this comment.
The motivation for using a-zA-Z0-9 instead of \w is that you don't want it to match for _ which is the only other character not matched by this change?
There was a problem hiding this comment.
For some searchers it was causing bad matches as outlined in #186 . For example, saying tester was a match when jumping on test. You can see evidence of this in the early commits for this PR with the ❌s, but here's a deep link to one example: https://travis-ci.org/jacktasia/dumb-jump/jobs/316563561
Thanks again for looking at this!
There was a problem hiding this comment.
This leads me to believe for these searchers with the options we give them \w is not recognized at all.
There was a problem hiding this comment.
Very weird but I see the point. Np :)
|
@netromdk Yup, thanks! |
#186