add grep prefix for grep tests to match other/later searchers (#187)

jacktasia · Dec 15, 2017 · 3d69721 · 3d69721
1 parent d78d82c
commit 3d69721
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/dumb-jump.el b/dumb-jump.el
@@ -1247,7 +1247,7 @@ matches when passed input from stdin, which is a crucial feature."
   (let ((thefile ".ag.test"))
     (dumb-jump-run-test-temp-file test thefile (concat cmd " " thefile))))
 
-(defun dumb-jump-test-rules (&optional run-not-tests)
+(defun dumb-jump-test-grep-rules (&optional run-not-tests)
   "Test all the grep rules and return count of those that fail.
 Optionally pass t for RUN-NOT-TESTS to see a list of all failed rules."
   (let ((fail-tmpl "grep FAILURE '%s' %s in response '%s' | CMD: '%s' | rule: '%s'")

diff --git a/test/dumb-jump-test.el b/test/dumb-jump-test.el
@@ -289,8 +289,8 @@
      (should (string= (buffer-file-name) js-file))
      (should (= (line-number-at-pos) 3)))))
 
-(ert-deftest dumb-jump-test-rules-test ()
-  (let ((rule-failures (dumb-jump-test-rules)))
+(ert-deftest dumb-jump-test-grep-rules-test ()
+  (let ((rule-failures (dumb-jump-test-grep-rules)))
     (dumb-jump-output-rule-test-failures rule-failures)
     (should (= (length rule-failures) 0))))
 
@@ -312,8 +312,8 @@
       (dumb-jump-output-rule-test-failures rule-failures)
       (should (= (length rule-failures) 0)))))
 
-(ert-deftest dumb-jump-test-rules-not-test () ;; :not tests
-  (let ((rule-failures (dumb-jump-test-rules t)))
+(ert-deftest dumb-jump-test-grep-rules-not-test () ;; :not tests
+  (let ((rule-failures (dumb-jump-test-grep-rules t)))
     (dumb-jump-output-rule-test-failures rule-failures)
     (should (= (length rule-failures) 0))))
 
@@ -329,10 +329,10 @@
       (dumb-jump-output-rule-test-failures rule-failures)
       (should (= (length rule-failures) 0)))))
 
-(ert-deftest dumb-jump-test-rules-fail-test ()
+(ert-deftest dumb-jump-test-grep-rules-fail-test ()
   (let* ((bad-rule '(:type "variable" :supports ("ag" "grep" "rg" "git-grep") :language "elisp" :regex "\\\(defvarJJJ\\b\\s*" :tests ("(defvar test ")))
          (dumb-jump-find-rules (cons bad-rule dumb-jump-find-rules))
-         (rule-failures (dumb-jump-test-rules)))
+         (rule-failures (dumb-jump-test-grep-rules)))
     ;(message "%s" (prin1-to-string rule-failures))
     (should (= (length rule-failures) 1))))