Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added one FAQ - describes that ztunnel is not a SPOF. #15305

Closed
wants to merge 4 commits into from

Conversation

ayushrakesh
Copy link
Contributor

Description

Clears misconception that ztunnel is not a Single Point of Failure.

#Resolves #15246

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

ayushrakesh and others added 4 commits June 19, 2024 11:55
Signed-off-by: ayushrakesh <ayushrakesh.05@gmail.com>
Signed-off-by: ayushrakesh <ayushrakesh.05@gmail.com>
Signed-off-by: ayushrakesh <ayushrakesh.05@gmail.com>
@ayushrakesh ayushrakesh requested a review from a team as a code owner June 19, 2024 07:16
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jun 19, 2024
@istio-testing
Copy link
Contributor

Hi @ayushrakesh. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ayushrakesh
Copy link
Contributor Author

@kfaseela @craigbox Please review it.

@kfaseela
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 19, 2024
@istio-testing
Copy link
Contributor

@ayushrakesh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io 32de8f8 link true /test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kfaseela
Copy link
Member

Please fix the lint failure.

@ayushrakesh ayushrakesh deleted the add-faq branch June 19, 2024 07:59
@kfaseela
Copy link
Member

@ayushrakesh you have to fix the lint failure in your document. The error can be seen at https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio.io/15305/lint_istio.io/1803333939767545856 , closing the PR and raising a new one will not fix the error

@ayushrakesh
Copy link
Contributor Author

@kfaseela Yes , I am fixing it.

@kfaseela
Copy link
Member

you need not close the PR, you can raise a new revision of the PR after fixing

@ayushrakesh
Copy link
Contributor Author

@kfaseela I have raised a new PR.

@kfaseela
Copy link
Member

@kfaseela I have raised a new PR.

what is the need for raising new PR everytime? why can't you revise existing PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ambient mode section to FAQ
3 participants