-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exposed outlierDetection configuration through GTP #217
Merged
shriramsharma
merged 1 commit into
istio-ecosystem:master
from
shriramsharma:expose_outlierdetection_104
May 19, 2022
Merged
exposed outlierDetection configuration through GTP #217
shriramsharma
merged 1 commit into
istio-ecosystem:master
from
shriramsharma:expose_outlierdetection_104
May 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shriramsharma
force-pushed
the
expose_outlierdetection_104
branch
from
May 13, 2022 16:07
122f6d9
to
05f3325
Compare
psikka1
approved these changes
May 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
nirvanagit
reviewed
May 16, 2022
nirvanagit
reviewed
May 16, 2022
nirvanagit
reviewed
May 16, 2022
nirvanagit
reviewed
May 16, 2022
nirvanagit
reviewed
May 16, 2022
nirvanagit
reviewed
May 17, 2022
nirvanagit
approved these changes
May 17, 2022
exposed outlierDetection configuration through GTP Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
shriramsharma
force-pushed
the
expose_outlierdetection_104
branch
from
May 19, 2022 22:20
7e2ad27
to
cc9ce6b
Compare
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
exposed outlierDetection configuration through GTP Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com> Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
Extended the GTP API to expose outlierDetection configuration.
Example GTP Config: