Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Make OutlierDetection params configurable #104

Closed
kenakamu opened this issue May 18, 2020 · 1 comment · Fixed by #217
Closed

[Enhancement] Make OutlierDetection params configurable #104

kenakamu opened this issue May 18, 2020 · 1 comment · Fixed by #217
Labels
enhancement New feature or request
Milestone
v1.3

Comments

@kenakamu
Copy link

Is there anyway to set outlierDetection? It seems to be hardcoded at the moment, but can we use GTP or other RD to define it?

outlierDetection:
      baseEjectionTime: 120s
      consecutive5xxErrors: 10
      interval: 5s
@kenakamu kenakamu added the bug Something isn't working label May 18, 2020
@kenakamu kenakamu changed the title [Question] [Question] How to set OutlierDetection May 18, 2020
@aattuluri aattuluri added enhancement New feature or request and removed bug Something isn't working labels May 18, 2020
@aattuluri aattuluri changed the title [Question] How to set OutlierDetection [Enhancement] Make OutlierDetection params configurable May 18, 2020
@aattuluri
Copy link
Contributor

@kenakamu Yep, I think GTP would be a good place but we need to define that in a simple way and not introduce a whole new configuration on top of Istio's DR. I open to any ideas. Also turning this to a Enhancement.

@aattuluri aattuluri added this to the v1.0 milestone Jun 17, 2020
@aattuluri aattuluri modified the milestones: v1.0, v1.1 Aug 26, 2020
@aattuluri aattuluri modified the milestones: v1.1, Nebulous Future Sep 2, 2020
@benchi benchi modified the milestones: Nebulous Future, v1.2 Nov 23, 2020
@aattuluri aattuluri modified the milestones: v1.2, v1.3 Jan 25, 2022
shriramsharma added a commit to shriramsharma/admiral that referenced this issue May 12, 2022
@shriramsharma
Fixes istio-ecosystem#104
122f6d9 
exposed outlierDetection configuration through GTP
@shriramsharma shriramsharma mentioned this issue May 12, 2022
Merged
shriramsharma added a commit to shriramsharma/admiral that referenced this issue May 13, 2022
@shriramsharma
Fixes istio-ecosystem#104
05f3325 
exposed outlierDetection configuration through GTP

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
shriramsharma added a commit to shriramsharma/admiral that referenced this issue May 19, 2022
@shriramsharma
Fixes istio-ecosystem#104
cc9ce6b 
exposed outlierDetection configuration through GTP

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
shriramsharma added a commit that referenced this issue May 19, 2022
@shriramsharma
Fixes #104 (#217)
059a0d5 
exposed outlierDetection configuration through GTP

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
psikka1 pushed a commit to psikka1/admiral that referenced this issue Jun 15, 2022
@shriramsharma @psikka1
Fixes istio-ecosystem#104 (istio-ecosystem#217)
f146f52 
exposed outlierDetection configuration through GTP

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk pushed a commit that referenced this issue Jul 21, 2022
@shriramsharma
Fixes #104 (#217)
c365664 
exposed outlierDetection configuration through GTP

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
itsLucario pushed a commit to itsLucario/admiral that referenced this issue Aug 9, 2022
MESH-1787 Add debug logging for events and generation (istio-ecosyste…
93391ee 
…m#104)

* MESH-1026 - Trigger pipeline

* Revert "MESH-1709 support bluegreen rollout preview (istio-ecosystem#103)"

This reverts commit 7d6991e.

* Revert "MESH-1709 support bluegreen rollout preview (istio-ecosystem#101)"

This reverts commit acca3f7.

* MESH-1787 - Undo preview endpoint generation and add informer logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

exposed outlierDetection configuration through GTP shriramsharma/admiral
3 participants
@benchi @kenakamu @aattuluri