-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add add_voxel in pybind for VoxelGrid::AddVoxel #6023
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
More commit for remove_voxel
|
Hi @ohkwon718 thanks for submitting this PR. Please update the code style to match Open3D code style by running:
|
I could use this feature. I hope it can be submitted! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-triggering CI. LGTM, once all are passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ohkwon718 for the useful feature! Thanks @reyanshsolis for your review.
I hope this update doesn't make any conflict with other features.
Regarding issues #2660, #1101, and #3133, there are needs for people to manually control voxels in VoxelGrid. Although it is already implemented in c++, there are no corresponding lines in pybind.
More discussions
This change is![Reviewable](https://github.com/camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)