Move benchmark config generation to build_e2e_test_artifacts #13291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzread
changed the title
pzread
changed the title
pzread
force-pushed
the
ci-central-bench-config
branch
from
c293df0
to
093dc25
Compare
pzread
force-pushed
the
ci-central-bench-config
branch
from
093dc25
to
c7bea5d
Compare
Abbreviated Benchmark Summary@ commit cafbb97d844c7ecbdf31b516ec97c70272291270 (vs. base 34e07706941838b442fbf21d1b615b54590d7f05) No improved or regressed benchmarks 🏖️ No improved or regressed compilation metrics 🏖️ For more information: |
pzread
changed the title
pzread
commented
Apr 25, 2023
| - name: "Downloading assets" | ||
| id: "download-assets" | ||
| env: | ||
| COMPILATION_CONFIG: ${{ steps.export.outputs.compilation-config }} | ||
| BENCHMARK_CONFIG: ${{ env.E2E_TEST_ARTIFACTS_DIR }}/compilation-benchmark-config.json | ||
| BENCHMARK_CONFIG_GCS_ARTIFACT: ${{ env.E2E_TEST_ARTIFACTS_GCS_ARTIFACT_DIR }}/compilation-benchmark-config.json |
There was a problem hiding this comment.
It looks tedious for me to export each artifact path from build_e2e_test_artifacts, so I choose to use hard-coded names for files under ${E2E_TEST_ARTIFACTS_DIR}.
pzread
added
infrastructure/benchmark
pzread
changed the title
pzread
changed the title
ScottTodd
approved these changes
Apr 25, 2023
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
When working on #13273, I noticed that benchmark configs and modules are uploaded in 3 different jobs. These artifacts can be uploaded to different GCS dirs when some of them are re-run due to failures (because re-run jobs will create [GCS_DIR with new run attempts](https://github.com/openxla/iree/blob/main/.github/workflows/benchmark_compilation.yml#L44-L50)). As a result, users might not be able to download all benchmark artifacts from a single GCS dir URL, which can be confusing. This PR changes the workflow to generate all benchmark modules and configs in `build_e2e_test_artifacts` to avoid such issue. All files are uploaded to `${GCS_URL}/e2e-test-artifacts`, a single path to download all benchmark artifacts. Besides the reason above, I think during the CMake build we should generate the benchmark configs under `${IREE_BUILD_DIR}/e2e_test_artifacts` instead of calling `export_benchmark_config.py` separately. There are some questions about how to pass the benchmark presets/filters through CMake configuration, so I decided to defer that as the next step.
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
…g#13291) When working on iree-org#13273, I noticed that benchmark configs and modules are uploaded in 3 different jobs. These artifacts can be uploaded to different GCS dirs when some of them are re-run due to failures (because re-run jobs will create [GCS_DIR with new run attempts](https://github.com/openxla/iree/blob/main/.github/workflows/benchmark_compilation.yml#L44-L50)). As a result, users might not be able to download all benchmark artifacts from a single GCS dir URL, which can be confusing. This PR changes the workflow to generate all benchmark modules and configs in `build_e2e_test_artifacts` to avoid such issue. All files are uploaded to `${GCS_URL}/e2e-test-artifacts`, a single path to download all benchmark artifacts. Besides the reason above, I think during the CMake build we should generate the benchmark configs under `${IREE_BUILD_DIR}/e2e_test_artifacts` instead of calling `export_benchmark_config.py` separately. There are some questions about how to pass the benchmark presets/filters through CMake configuration, so I decided to defer that as the next step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #13273, I noticed that benchmark configs and modules are uploaded in 3 different jobs. These artifacts can be uploaded to different GCS dirs when some of them are re-run due to failures (because re-run jobs will create GCS_DIR with new run attempts). As a result, users might not be able to download all benchmark artifacts from a single GCS dir URL, which can be confusing.
This PR changes the workflow to generate all benchmark modules and configs in
build_e2e_test_artifactsto avoid such issue. All files are uploaded to${GCS_URL}/e2e-test-artifacts, a single path to download all benchmark artifacts.Besides the reason above, I think during the CMake build we should generate the benchmark configs under
${IREE_BUILD_DIR}/e2e_test_artifactsinstead of callingexport_benchmark_config.pyseparately. There are some questions about how to pass the benchmark presets/filters through CMake configuration, so I decided to defer that as the next step.