Post GCS links in CI summary #13273
Merged
Post GCS links in CI summary #13273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzread
force-pushed
the
ci-show-links
branch
9 times, most recently
from
94df187
to
54591bb
Compare
pzread
force-pushed
the
ci-show-links
branch
2 times, most recently
from
7d94927
to
070e5f4
Compare
pzread
pushed a commit
that referenced
this pull request
Apr 26, 2023
When working on #13273, I noticed that benchmark configs and modules are uploaded in 3 different jobs. These artifacts can be uploaded to different GCS dirs when some of them are re-run due to failures (because re-run jobs will create [GCS_DIR with new run attempts](https://github.com/openxla/iree/blob/main/.github/workflows/benchmark_compilation.yml#L44-L50)). As a result, users might not be able to download all benchmark artifacts from a single GCS dir URL, which can be confusing. This PR changes the workflow to generate all benchmark modules and configs in `build_e2e_test_artifacts` to avoid such issue. All files are uploaded to `${GCS_URL}/e2e-test-artifacts`, a single path to download all benchmark artifacts. Besides the reason above, I think during the CMake build we should generate the benchmark configs under `${IREE_BUILD_DIR}/e2e_test_artifacts` instead of calling `export_benchmark_config.py` separately. There are some questions about how to pass the benchmark presets/filters through CMake configuration, so I decided to defer that as the next step.
pzread
force-pushed
the
ci-show-links
branch
3 times, most recently
from
a1a40f2
to
68f4287
Compare
pzread
changed the title
ScottTodd
reviewed
Apr 26, 2023
Comment on lines
+1099
to
+1101
| run: | | ||
| cat <<EOF >> "${GITHUB_STEP_SUMMARY}" | ||
| ### :link: Artifact Links |
There was a problem hiding this comment.
Nice! This job summary is so convenient
ScottTodd
added
infrastructure
ScottTodd
approved these changes
Apr 26, 2023
19 tasks
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
When working on #13273, I noticed that benchmark configs and modules are uploaded in 3 different jobs. These artifacts can be uploaded to different GCS dirs when some of them are re-run due to failures (because re-run jobs will create [GCS_DIR with new run attempts](https://github.com/openxla/iree/blob/main/.github/workflows/benchmark_compilation.yml#L44-L50)). As a result, users might not be able to download all benchmark artifacts from a single GCS dir URL, which can be confusing. This PR changes the workflow to generate all benchmark modules and configs in `build_e2e_test_artifacts` to avoid such issue. All files are uploaded to `${GCS_URL}/e2e-test-artifacts`, a single path to download all benchmark artifacts. Besides the reason above, I think during the CMake build we should generate the benchmark configs under `${IREE_BUILD_DIR}/e2e_test_artifacts` instead of calling `export_benchmark_config.py` separately. There are some questions about how to pass the benchmark presets/filters through CMake configuration, so I decided to defer that as the next step.
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
Post useful artifact links in the summary. They should help people find the GCS links to download artifacts from CI, instead of looking into the build log.
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
…g#13291) When working on iree-org#13273, I noticed that benchmark configs and modules are uploaded in 3 different jobs. These artifacts can be uploaded to different GCS dirs when some of them are re-run due to failures (because re-run jobs will create [GCS_DIR with new run attempts](https://github.com/openxla/iree/blob/main/.github/workflows/benchmark_compilation.yml#L44-L50)). As a result, users might not be able to download all benchmark artifacts from a single GCS dir URL, which can be confusing. This PR changes the workflow to generate all benchmark modules and configs in `build_e2e_test_artifacts` to avoid such issue. All files are uploaded to `${GCS_URL}/e2e-test-artifacts`, a single path to download all benchmark artifacts. Besides the reason above, I think during the CMake build we should generate the benchmark configs under `${IREE_BUILD_DIR}/e2e_test_artifacts` instead of calling `export_benchmark_config.py` separately. There are some questions about how to pass the benchmark presets/filters through CMake configuration, so I decided to defer that as the next step.
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
Post useful artifact links in the summary. They should help people find the GCS links to download artifacts from CI, instead of looking into the build log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post useful artifact links in the summary. They should help people find the GCS links to download artifacts from CI, instead of looking into the build log.
GCS links are posted as shell commands. So users can directly copy-and-paste in their shells and follow docs to run commands.
Sample: https://github.com/openxla/iree/actions/runs/4811766984/attempts/1#summary-13047887449
