Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show friendly name when building e2e test modules #12693

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

pzread
Copy link
Contributor

@pzread pzread commented Mar 20, 2023

Display friendly full name of ModuleGenerationConfig when building e2e test artifacts.

The purpose is to help people debug the build failures in e2e test artifacts and find the sources where those build rules are generated.

@pzread pzread force-pushed the bench-info branch 2 times, most recently from 22f8650 to 01db02c Compare March 20, 2023 21:42
@pzread pzread changed the title Show friendly name when building modules Show friendly name when building e2e test modules Mar 20, 2023
@pzread pzread marked this pull request as ready for review March 20, 2023 21:45
Copy link
Contributor

@GMNGeoffrey GMNGeoffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this isn't being used in the CMake? I'm confused

@GMNGeoffrey
Copy link
Contributor

It looks like this isn't being used in the CMake? I'm confused

Oh I see that's already a parameter to iree_bytecode_module and the regenerated CMake was hidden by GitHub

@pzread pzread merged commit 9dfa052 into iree-org:main Mar 21, 2023
pzread pushed a commit that referenced this pull request Mar 21, 2023
#12693 is merged after #12690 and #12537 without regenerating the cmake
files (the presubmit was passed before the other two PRs merged).
Regenerated the cmake files.
qedawkins pushed a commit to qedawkins/iree that referenced this pull request Apr 2, 2023
qedawkins pushed a commit to qedawkins/iree that referenced this pull request Apr 2, 2023
iree-org#12693 is merged after iree-org#12690 and iree-org#12537 without regenerating the cmake
files (the presubmit was passed before the other two PRs merged).
Regenerated the cmake files.
@jpienaar jpienaar mentioned this pull request Apr 3, 2023
jpienaar pushed a commit that referenced this pull request May 1, 2023
#12693 is merged after #12690 and #12537 without regenerating the cmake
files (the presubmit was passed before the other two PRs merged).
Regenerated the cmake files.
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this pull request Jul 6, 2023
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this pull request Jul 6, 2023
iree-org#12693 is merged after iree-org#12690 and iree-org#12537 without regenerating the cmake
files (the presubmit was passed before the other two PRs merged).
Regenerated the cmake files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants