-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show friendly name when building e2e test modules #12693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzread
force-pushed
the
bench-info
branch
2 times, most recently
from
March 20, 2023 21:42
22f8650
to
01db02c
Compare
pzread
changed the title
Show friendly name when building modules
Show friendly name when building e2e test modules
Mar 20, 2023
GMNGeoffrey
reviewed
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this isn't being used in the CMake? I'm confused
Oh I see that's already a parameter to |
GMNGeoffrey
approved these changes
Mar 20, 2023
pzread
pushed a commit
that referenced
this pull request
Mar 21, 2023
19 tasks
qedawkins
pushed a commit
to qedawkins/iree
that referenced
this pull request
Apr 2, 2023
qedawkins
pushed a commit
to qedawkins/iree
that referenced
this pull request
Apr 2, 2023
iree-org#12693 is merged after iree-org#12690 and iree-org#12537 without regenerating the cmake files (the presubmit was passed before the other two PRs merged). Regenerated the cmake files.
Merged
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
iree-org#12693 is merged after iree-org#12690 and iree-org#12537 without regenerating the cmake files (the presubmit was passed before the other two PRs merged). Regenerated the cmake files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display friendly full name of
ModuleGenerationConfig
when building e2e test artifacts.The purpose is to help people debug the build failures in e2e test artifacts and find the sources where those build rules are generated.