Fix XLA import path #12898
Merged
Fix XLA import path #12898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pipeline wasn't following the route documented post refactoring, which led to tuples not being handled correctly: the flatten tuple pass required CF form to operate on and not SCF form. We can make this a bit more automatic (and we have the tracking bug to avoid even specifying type here).
jpienaar
requested review from
hanhanW,
MaheshRavishankar,
rsuderman and
benvanik
as code owners
jpienaar
requested review from
dellis23
and removed request for
benvanik,
MaheshRavishankar and
hanhanW
dellis23
approved these changes
Apr 3, 2023
jpienaar
added a commit
that referenced
this pull request
May 1, 2023
The pipeline wasn't following the route documented post refactoring, which led to tuples not being handled correctly: the flatten tuple pass required CF form to operate on and not SCF form. We can make this a bit more automatic (and we have the tracking bug to avoid even specifying type here). This is for the legacy import path.
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
The pipeline wasn't following the route documented post refactoring, which led to tuples not being handled correctly: the flatten tuple pass required CF form to operate on and not SCF form. We can make this a bit more automatic (and we have the tracking bug to avoid even specifying type here). This is for the legacy import path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipeline wasn't following the route documented post refactoring,
which led to tuples not being handled correctly: the flatten tuple pass
required CF form to operate on and not SCF form.
We can make this a bit more automatic (and we have the tracking bug to
avoid even specifying type here).
This is for the legacy import path.