Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add explicit flash_attn requirement for ROCm (backport #255) #258

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 8, 2024


This is an automatic backport of pull request #255 done by [Mergify](https://mergify.com).

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
(cherry picked from commit d74105a)
Copy link
Contributor

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added release-branch dependencies Pull requests that update a dependency file one-approval labels Oct 8, 2024
@mergify mergify bot removed the one-approval label Oct 8, 2024
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 097fdd0 into release-v0.5 Oct 8, 2024
13 checks passed
@mergify mergify bot deleted the mergify/bp/release-v0.5/pr-255 branch October 8, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file release-branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants