Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add explicit flash_attn requirement for ROCm #255

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

fabiendupont
Copy link
Contributor

No description provided.

@mergify mergify bot added the dependencies Pull requests that update a dependency file label Oct 7, 2024
Signed-off-by: Fabien Dupont <fdupont@redhat.com>
@nathan-weinberg nathan-weinberg changed the title RHELAI-1729: Add explicit flash_attn requirement for ROCm Add explicit flash_attn requirement for ROCm Oct 7, 2024
@fabiendupont fabiendupont changed the title Add explicit flash_attn requirement for ROCm fix: Add explicit flash_attn requirement for ROCm Oct 7, 2024
Copy link
Contributor

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maxusmusti Maxusmusti removed the hold label Oct 7, 2024
@mergify mergify bot added the one-approval label Oct 7, 2024
@mergify mergify bot merged commit 8579069 into instructlab:main Oct 7, 2024
13 checks passed
@mergify mergify bot removed the one-approval label Oct 7, 2024
@Maxusmusti
Copy link
Contributor

@Mergifyio backport release-v0.5

Copy link
Contributor

mergify bot commented Oct 8, 2024

backport release-v0.5

✅ Backports have been created

mergify bot added a commit that referenced this pull request Oct 8, 2024
fix: Add explicit flash_attn requirement for ROCm (backport #255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants