Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: remove ibc from basecoin-store #149

Merged
merged 7 commits into from
Jan 22, 2024
Merged

imp: remove ibc from basecoin-store #149

merged 7 commits into from
Jan 22, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Jan 22, 2024 •
edited
Loading

Closes: #148

Description

As a result of this PR, I think it should be possible to import basecoin-store into the ibc-testkit without having to port the code (this issue).

Along with this PR:

  • Removed redundant basecoin-store dependencies.
  • Removed basecoin_store::types::Path tests that was never failing.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review January 22, 2024 04:11
rnbguy
rnbguy approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@Farhad-Shabani Farhad-Shabani merged commit dc3b43a into main Jan 22, 2024
10 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/decouple-store-from-ibc branch January 22, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnbguy rnbguy rnbguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decouple basecoin-store from ibc crate
2 participants
@Farhad-Shabani @rnbguy