Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(testkit): adopt basecoin-store in ibc-testkit #1045

Closed
rnbguy opened this issue Jan 18, 2024 · 1 comment · Fixed by #1109
Closed

imp(testkit): adopt basecoin-store in ibc-testkit #1045

rnbguy opened this issue Jan 18, 2024 · 1 comment · Fixed by #1109
Assignees
Milestone

Comments

@rnbguy
Copy link
Collaborator

rnbguy commented Jan 18, 2024

Feature Summary

Currently, ibc-testkit uses a MockContext with a very minimalistic data structure. We want to improve this to capture more adversarial scenarios.

To achieve this, along with other refactors, we must introduce a blockchain-compatible store like Merkle Tree.

basecoin already has a working Merkle tree with a helpful set of store data structures and types. We want to move the store crate from there under ibc-testkit. We may directly use it when it is published on crates.io.

Proposal

<= 0.49.1

@rnbguy rnbguy self-assigned this Jan 18, 2024
@Farhad-Shabani Farhad-Shabani added O: testing Objective: aims to improve testing coverage and removed O: testing Objective: aims to improve testing coverage labels Jan 19, 2024
@rnbguy rnbguy changed the title adopt basecoin-store under ibc-testkit imp(testkit): adopt basecoin-store in ibc-testkit Jan 30, 2024
@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Feb 1, 2024
@Farhad-Shabani Farhad-Shabani modified the milestones: 0.51.0, 0.52.0 Mar 27, 2024
@rnbguy
Copy link
Collaborator Author

rnbguy commented May 4, 2024

closed by #1109

@rnbguy rnbguy closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants