Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When compositeSearchHeight and excludeFromCompositeBuild are set wrong, useless NullPointerException #63

Open
jespersmith opened this issue Aug 17, 2018 · 6 comments

Comments

@jespersmith
Copy link

####Steps to reproduce issue

  • Check out a project that does not depend on any other source project
  • Set compositeSearchHeight to 1 and excludeFromCompositeBuild to false
  • Run gradle build

####Expected behavior

A useful error that tells the user what is wrong

####Actual behavior

FAILURE: Build failed with an exception.

* What went wrong:
java.lang.NullPointerException (no error message)

####Contributors with relevant knowledge or expertise (optional)

@calvertdw

@calvertdw
Copy link
Member

Just to confirm, which version are you using?

@jespersmith
Copy link
Author

ihmc-java-ros2-communication uses "us.ihmc:ihmc-build:0.14.0"

@calvertdw
Copy link
Member

Okay, thanks. I'll fix in the next release.

@calvertdw
Copy link
Member

Putting this here for my notes.

  1. Find origin of NPE
  2. Handle that situation without crashing
  3. Depending on what it is, either warn or continue silently

@calvertdw
Copy link
Member

@jespersmith This must be a result of a specific situation where it tries to search the 1 height and NPEs on something. I cannot reproduce. If you give me the full stack trace I can add a NPE check.

@calvertdw calvertdw reopened this Oct 11, 2018
@calvertdw
Copy link
Member

Did not mean to close that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants