Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate temp filename template #1428

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

cme
Copy link
Contributor

@cme cme commented Dec 22, 2021

Make sure that filename templates will yield valid filenames. This is an issue since pattern names are used as basenames when modifying sequences, and these are not necessarily valid filenames.

@cme cme changed the base branch from releases/1.1 to master December 22, 2021 21:24
@cme cme changed the base branch from master to releases/1.1 December 22, 2021 21:25
@cme cme merged commit 7fa5b6b into hydrogen-music:releases/1.1 Dec 22, 2021
@theGreatWhiteShark
Copy link
Contributor

Well, guess what happens when renaming a drumkit to ../../../something. 😄

I'll have a look at if. Maybe this is a good opportunity to fix #793 along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants