Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Could not save pattern to temporary directory." (Pattern names used as temporary filenames) #1425

Closed
cme opened this issue Dec 21, 2021 · 2 comments
Milestone

Comments

@cme
Copy link
Contributor

cme commented Dec 21, 2021

Hydrogen version * : 1.1.1 + all others
Operating system + version : All (Windows in particular)


The Song Editor uses pattern names, without escapes, as the basenames for temporary files used to store patterns when deleting patterns.

No restrictions are placed on pattern names in the Song Editor, so there's no guarantee they will be valid filenames on the host platform. Particularly on Windows where things like '~', '', '::' etc aren't valid in filenames (and on other platforms, '/').

To reproduce:

  • create a pattern named Pattern 1/2\3~4::5
  • try to delete it

(This is first noted in discussion in #1047)

@theGreatWhiteShark
Copy link
Contributor

Nice find!

@cme
Copy link
Contributor Author

cme commented Jan 8, 2022

Fixed with #1428

@cme cme closed this as completed Jan 8, 2022
@cme cme added this to the 1.2 milestone Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants