Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin numpy<2.0 #32018

Merged
merged 2 commits into from
Jul 18, 2024
Merged

unpin numpy<2.0 #32018

merged 2 commits into from
Jul 18, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jul 17, 2024 •
edited
Loading

What does this PR do?

As discussed internally, let's allow the community to run transformers with numpy=2.x

Fix #31802

@ydshieh
Copy link
Collaborator Author

ydshieh commented Jul 17, 2024

Note, our CI is still running with numpy < 2.0 as the dependency would resolve to a version < 2 at the end.

@ydshieh ydshieh requested a review from amyeroberts July 17, 2024 10:08
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

amyeroberts
amyeroberts approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydshieh ydshieh merged commit 765732e into main Jul 18, 2024
22 checks passed
@ydshieh ydshieh deleted the unpin_np branch July 18, 2024 09:26
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jul 19, 2024
@ydshieh @amyeroberts
unpin numpy<2.0 (huggingface#32018)
ab95a51 
* unpin np

* [test_all] trigger full CI

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
MHRDYN7 pushed a commit to MHRDYN7/transformers that referenced this pull request Jul 23, 2024
@ydshieh @MHRDYN7
unpin numpy<2.0 (huggingface#32018)
91efb62 
* unpin np

* [test_all] trigger full CI

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jul 24, 2024
@ydshieh @zucchini-nlp
unpin numpy<2.0 (huggingface#32018)
314bf17 
* unpin np

* [test_all] trigger full CI

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
itazap pushed a commit that referenced this pull request Jul 25, 2024
@ydshieh @itazap
unpin numpy<2.0 (#32018)
5fb093f 
* unpin np

* [test_all] trigger full CI

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
@albertvillanova albertvillanova mentioned this pull request Aug 21, 2024
Merged
@h3110Fr13nd h3110Fr13nd mentioned this pull request Oct 4, 2024
Merged
3 tasks
dataKim1201 pushed a commit to dataKim1201/transformers that referenced this pull request Oct 7, 2024
@ydshieh @dataKim1201
unpin numpy<2.0 (huggingface#32018)
83f203b 
* unpin np

* [test_all] trigger full CI

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please support numpy 2.0
3 participants
@ydshieh @HuggingFaceDocBuilderDev @amyeroberts