Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove numpy version constraint in setup.py #2039

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Remove numpy version constraint in setup.py #2039

merged 1 commit into from
Oct 8, 2024

Conversation

h3110Fr13nd
Copy link
Contributor

@h3110Fr13nd h3110Fr13nd commented Oct 4, 2024 •
edited
Loading

What does this PR do?

The version constraint for numpy<2.0 in transformers has been removed by @ydshieh in huggingface/transformers#32018

Fixes #2037

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@h3110Fr13nd h3110Fr13nd marked this pull request as ready for review October 4, 2024 16:13
@IlyasMoutawwakil IlyasMoutawwakil merged commit d9754ab into huggingface:main Oct 8, 2024
55 of 60 checks passed
@echarlaix echarlaix mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimum 1.22 still requires numpy<2.0
2 participants
@h3110Fr13nd @IlyasMoutawwakil