transformers v4.45 support #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
echarlaix
requested review from
michaelbenayoun,
JingyaHuang and
IlyasMoutawwakil
echarlaix
commented
Sep 30, 2024
Comment on lines
+1004
to
+1007
| if check_if_transformers_greater("4.44.99"): | ||
| raise ImportError( | ||
| f"ONNX conversion disabled for now for transformers version greater than v4.45, found {transformers.__version__}" | ||
| ) |
There was a problem hiding this comment.
disabling onnx export as additional fixes are needed (but don't want to block the latest transformers release for other subpackages) @michaelbenayoun @xenova
There was a problem hiding this comment.
Ok to me, maybe specify that it's temporary.
michaelbenayoun
approved these changes
Sep 30, 2024
Comment on lines
+95
to
+96
| # Adapted from transformers.models.gptj.modeling_gptj.GPTJAttention._attn | ||
| def gptj_wrapped_scaled_dot_product( |
There was a problem hiding this comment.
nit: maybe add docstring on how this custom implementation solves the problem.
Comment on lines
+1004
to
+1007
| if check_if_transformers_greater("4.44.99"): | ||
| raise ImportError( | ||
| f"ONNX conversion disabled for now for transformers version greater than v4.45, found {transformers.__version__}" | ||
| ) |
There was a problem hiding this comment.
Ok to me, maybe specify that it's temporary.
|
failing tests unrelated, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.