Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformers v4.45 support #902

Merged
merged 25 commits into from
Sep 26, 2024
Merged

Add transformers v4.45 support #902

merged 25 commits into from
Sep 26, 2024

Conversation

echarlaix
Copy link
Collaborator

@echarlaix echarlaix commented Sep 16, 2024

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix echarlaix marked this pull request as ready for review September 25, 2024 17:03
@echarlaix echarlaix added the openvino-test Trigger OpenVINO slow tests label Sep 26, 2024
@echarlaix
Copy link
Collaborator Author

One test is failing still but not related to this PR directly, the failing test is for codegen2 coming from codegen_wrapped_scaled_dot_product after huggingface/optimum@9fa9e9f in optimum that was added to match with the new transformers release. The issue comes from the modeling mismatch between the transformers since v4.45 and the modeling file from the test modeling repo https://huggingface.co/katuni4ka/tiny-random-codegen2/blob/main/modeling_codegen.py cc @eaidova

@echarlaix echarlaix merged commit d3c8ac6 into main Sep 26, 2024
18 of 24 checks passed
@echarlaix echarlaix deleted the trfs-4.45 branch September 26, 2024 15:45
@@ -28,7 +28,7 @@

INSTALL_REQUIRE = [
"torch>=1.11",
"transformers>=4.36,<4.45",
"transformers>=4.36,<4.46",
"optimum~=1.22",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should optimum version be also updated? As it was there 2b621cf

Otherwise, optimum forces older transformers version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that will be done in this PR #926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openvino-test Trigger OpenVINO slow tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants