Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in docs/a_quick_tour.mdx #419

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Fix broken link in docs/a_quick_tour.mdx #419

merged 2 commits into from
Mar 14, 2023

Conversation

tupini07
Copy link
Contributor

@tupini07 tupini07 commented Feb 8, 2023

In the Save and push to the Hub section there is a link which goes to a 404 page:

huggingface/datasets@master/src/datasets/utils/resources/tasks.json

As suggested in #417 , I'm opening a new PR to fix this link so that it points to the respective lines in evaluate/src/evaluate/config.py .

The file reference is pinned to the current HEAD commit of main (7fa754c), this ensures that the reference will always work (since it's a permalink) but it also means that it might eventually get stale. Should not pin the link to a specific commit?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 15, 2023

The documentation is not available anymore as the PR was closed or merged.

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@lvwerra lvwerra merged commit ef9ec16 into huggingface:main Mar 14, 2023
@tupini07 tupini07 deleted the docs-fix-tasks-link branch March 14, 2023 21:16
unna97 pushed a commit to unna97/evaluate that referenced this pull request Mar 20, 2023
* replace link with reference to config.py

* Update docs/source/a_quick_tour.mdx

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>

---------

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants