Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo in a_quick_tour.mdx #417

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fix minor typo in a_quick_tour.mdx #417

merged 2 commits into from
Feb 15, 2023

Conversation

tupini07
Copy link
Contributor

@tupini07 tupini07 commented Feb 7, 2023

This PR adds a missing comma in a call to evaluate.save, also a missing definite article near the end 😄

I know this is a PR and not an issue, but I noticed in the Save and push to the Hub section there is a link which goes to a 404 page:

https://github.com/huggingface/datasets/blob/master/src/datasets/utils/resources/tasks.json

I looked a bit through the datasets repo but couldn't find an alternative tasks.json. Maybe we should change it to go to one of these pages instead? I can add this change as part of this PR if you want 🙂

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

As for the tasks, yes, the tasks.json was removed from datasets - we moved it internally and I think we can just link to:

HF_HUB_ALLOWED_TASKS = [
"image-classification",
"translation",
"image-segmentation",
"fill-mask",
"automatic-speech-recognition",
"token-classification",
"sentence-similarity",
"audio-classification",
"question-answering",
"summarization",
"zero-shot-classification",
"table-to-text",
"feature-extraction",
"other",
"multiple-choice",
"text-classification",
"text-to-image",
"text2text-generation",
"zero-shot-image-classification",
"tabular-classification",
"tabular-regression",
"image-to-image",
"tabular-to-text",
"unconditional-image-generation",
"text-retrieval",
"text-to-speech",
"object-detection",
"audio-to-audio",
"text-generation",
"conversational",
"table-question-answering",
"visual-question-answering",
"image-to-text",
"reinforcement-learning",
"voice-activity-detection",
"time-series-forecasting",
"document-question-answering",
]

Want to open another PR?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 8, 2023

The documentation is not available anymore as the PR was closed or merged.

@tupini07
Copy link
Contributor Author

tupini07 commented Feb 8, 2023

Thanks @lvwerra ! Sure 😄 I'll go ahead and open another PR to fix the tasks.json link

@lvwerra lvwerra merged commit 6ced7f5 into huggingface:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants