Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor evaluator tests #155

Merged
merged 3 commits into from
Jun 27, 2022
Merged

refactor evaluator tests #155

merged 3 commits into from
Jun 27, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jun 23, 2022

Since IMDb is currently unavailable, also the evaluator tests have been failing (See #154). I took this as an opportunity to refactor the tests a bit:

  • dataset: now the dataset is just a dummy dataset and does not rely on the hub.
  • pipeline: in most places I replaced the pipeline with a dummy pipeline so we also don't rely on the hub. after all we want to test the evaluator and not loading the model from the hub. only where e.g. loading via string is tested a model is still downloaded but we could probably also mock this in the future.

Let me know what you think.

@lvwerra lvwerra requested a review from ola13 June 23, 2022 15:57
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 23, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@ola13 ola13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @lvwerra

@lvwerra lvwerra merged commit 4f5b1f2 into main Jun 27, 2022
@lvwerra lvwerra deleted the fix-evaluator-test-imdb branch June 27, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants