Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tutorial for custom pipeline #154

Merged
merged 1 commit into from
Jun 27, 2022
Merged

add tutorial for custom pipeline #154

merged 1 commit into from
Jun 27, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jun 23, 2022

This PR adds a guide for how to use the evaluator with a custom pipeline. Specifically, it shows how to wrap it for a Scikit-Learn or Spacy mode.

@lvwerra lvwerra requested review from ola13 and sashavor June 23, 2022 13:06
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 23, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra mentioned this pull request Jun 23, 2022
Merged
ola13
ola13 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@ola13 ola13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I wonder if we'd also like to add tests for Scikit-Learn and scipy pipelines?

sashavor
sashavor approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME! 🤩

@lvwerra
Copy link
Member Author

lvwerra commented Jun 27, 2022

@ola13: the DummyTextClassificationPipeline is essentially the same as this. I don't think we want to explicitly test the sklearn or spacy dependency if we don't integrate the wrappers into the library. If at some point we do that I agree we should test it.

@lvwerra lvwerra merged commit b75f335 into main Jun 27, 2022
@lvwerra lvwerra deleted the add-custom-pipeline-evaluator branch June 27, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ola13 ola13 ola13 approved these changes

@sashavor sashavor sashavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lvwerra @HuggingFaceDocBuilderDev @ola13 @sashavor