-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle server code with webpack #578
Merged
forabi
merged 7 commits into
hollowverse-archive:beta
from
forabi:bundle-server-with-webpack
Sep 9, 2018
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e6d19f9
Bundle server code with webpack
forabi 2457e91
Externalize aws-sdk, helmet
forabi 5f80159
Restore build commands
forabi a4dec43
Run copy-defs before packaging
forabi b8c3887
Remove old build command
forabi f6fa087
Externalize encoding, keyv
forabi 92e56ca
Revert "Externalize encoding, keyv"
forabi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
const webpack = require('webpack'); | ||
const webpackMerge = require('webpack-merge'); | ||
const slsw = require('serverless-webpack'); | ||
const CopyWebpackPlugin = require('copy-webpack-plugin'); | ||
const UglifyJsPlugin = require('uglifyjs-webpack-plugin'); | ||
|
||
const path = require('path'); | ||
const { compact } = require('lodash'); | ||
|
||
const { createScriptRules } = require('./helpers'); | ||
const { createBaseConfig } = require('./createBaseConfig'); | ||
|
||
const common = createBaseConfig(); | ||
|
||
const serverSpecificConfig = { | ||
entry: slsw.lib.entries, | ||
target: 'node', | ||
node: { | ||
__dirname: true, | ||
}, | ||
|
||
devtool: false, | ||
|
||
externals: ['express', 'http-proxy-middleware', 'helmet', 'aws-sdk'], | ||
|
||
optimization: { | ||
minimizer: [ | ||
new UglifyJsPlugin({ | ||
uglifyOptions: { | ||
keep_classnames: true, | ||
compress: { | ||
inline: false, | ||
}, | ||
}, | ||
}), | ||
], | ||
}, | ||
|
||
output: { | ||
libraryTarget: 'commonjs', | ||
path: path.resolve(__dirname, '.webpack'), | ||
filename: '[name].js', | ||
}, | ||
|
||
stats: 'minimal', | ||
|
||
module: { | ||
rules: compact([ | ||
// JavaScript and TypeScript | ||
...createScriptRules({ isNode: true }), | ||
]), | ||
}, | ||
|
||
resolve: { | ||
modules: [path.join(__dirname, '..')], | ||
}, | ||
|
||
plugins: compact([ | ||
new webpack.IgnorePlugin(/^electron$/), | ||
new webpack.IgnorePlugin(/^yamlparser$/), | ||
|
||
// @ts-ignore | ||
new CopyWebpackPlugin([{ from: 'dist', to: 'dist' }]), | ||
]), | ||
}; | ||
|
||
module.exports = webpackMerge(common, serverSpecificConfig); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If webpack builds a single JS bundle, that includes all the dependencies, why do you need to
includeModules
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there are still some packages not bundled with webpack due to incompatibilities. Those are defined in the
externals
field of the webpack config.