Bundle server code with webpack #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forabi
force-pushed
the
bundle-server-with-webpack
branch
from
d6e051c
to
e6d19f9
Compare
| webpack: | ||
| packager: 'yarn' | ||
| webpackConfig: ./src/webpack/webpack.config.server.js | ||
| includeModules: true |
There was a problem hiding this comment.
If webpack builds a single JS bundle, that includes all the dependencies, why do you need to includeModules?
There was a problem hiding this comment.
Because there are still some packages not bundled with webpack due to incompatibilities. Those are defined in the externals field of the webpack config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the deployment package into 2 ZIP files (one for each function), each is around ~7MB. The package size for
serveLogEndpointcould be reduced even further if there was an easy way to makeserverless-webpackrespect the per-functionincludeoption of Serverless.Fixes #569