Feature metric jsd #66

sjh120 · 2023-12-15T07:49:14Z

Description

JSD实现

Motivation and Context

Resolves #40

How has this been tested?

通过修改1_ctgan_example.py中selected_columns字段选择要选取的列，isDiscrete字段表示是否选取离散列或连续列，将计算多列联合概率密度的JS散度

Types of changes

Maintenance (no change in code, maintain the project's CI, docs, etc.)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

for more information, see https://pre-commit.ci

Co-authored-by: Zhongsheng Ji <9573586@qq.com>

for more information, see https://pre-commit.ci

sweep-ai · 2023-12-15T07:50:18Z

Apply Sweep Rules to your PR?

Apply: All new business logic should have corresponding unit tests.
Apply: Refactor large functions to be more modular.
Apply: Add docstrings to all functions and file headers.

Wh1isper

Please remove all .idea/* files, you can add .idea/ in root's .gitignore

You can just pick .gitignore file in main branch: 35beee7#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947

MooooCat · 2023-12-17T02:09:23Z

@sjh120 Please sync the base class currently in branch "feature-metric-base".

This PR should only contains the following files：

example/1_ctgan_example.py
sdgx/metrics/column/jsd.py

…e-metric-base # Conflicts: # sdgx/metrics/column/base.py # sdgx/metrics/single_table/base.py

for more information, see https://pre-commit.ci

sjh120 · 2023-12-17T09:10:32Z

已修改，对base.py的修改为直接pull base class in branch "feature-metric-base"的结果

Wh1isper

LGTM, as a demo.

But it's probably not a good idea to directly modify an existing example...

What do you think? @MooooCat

* Feature metric jsd (#66) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * jsd * jsd * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * base更新 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Delete .idea directory --------- Co-authored-by: Jinhang Su <171846802@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: MoooCat <141886018+MooooCat@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Update type hint and comments. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Jinhang Su <171846802@qq.com> Co-authored-by: sjh120 <171846802@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com>

* Update metric base-class * Update column metric base class * Update Metric Base Class * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Feature: Add metric jsd (#66) (#71) * Feature metric jsd (#66) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * jsd * jsd * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * base更新 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Delete .idea directory --------- Co-authored-by: Jinhang Su <171846802@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: MoooCat <141886018+MooooCat@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Update type hint and comments. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Jinhang Su <171846802@qq.com> Co-authored-by: sjh120 <171846802@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typo error unnecessary imports are also removed. * Add type hints and comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update input check methods The format of some codes has also been adjusted. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> Co-authored-by: Jinhang Su <171846802@qq.com>

pre-commit-ci bot and others added 5 commits December 11, 2023 02:14

[pre-commit.ci] auto fixes from pre-commit.com hooks

e250ddb

for more information, see https://pre-commit.ci

Apply suggestions from code review

41f463a

Co-authored-by: Zhongsheng Ji <9573586@qq.com>

jsd

3d70b5a

jsd

40162f5

[pre-commit.ci] auto fixes from pre-commit.com hooks

4e2ac5f

for more information, see https://pre-commit.ci

Wh1isper requested changes Dec 16, 2023

View reviewed changes

Wh1isper linked an issue Dec 16, 2023 that may be closed by this pull request

[Feature]🌌Jensen–Shannon divergence Implementation #40

Closed

sjh120 and others added 4 commits December 17, 2023 16:44

Merge remote-tracking branch 'origin/feature-metric-base' into featur…

acded18

…e-metric-base # Conflicts: # sdgx/metrics/column/base.py # sdgx/metrics/single_table/base.py

base更新

6e05d30

[pre-commit.ci] auto fixes from pre-commit.com hooks

2449d21

for more information, see https://pre-commit.ci

Delete .idea directory

181f345

Wh1isper approved these changes Dec 17, 2023

View reviewed changes

MooooCat merged commit 9bea673 into hitsz-ids:feature-metric-jsd Dec 17, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature metric jsd #66

Feature metric jsd #66

sjh120 commented Dec 15, 2023 •

edited by Wh1isper

Loading

sweep-ai bot commented Dec 15, 2023

Wh1isper left a comment •

edited

Loading

MooooCat commented Dec 17, 2023

sjh120 commented Dec 17, 2023

Wh1isper left a comment

Feature metric jsd #66

Feature metric jsd #66

Conversation

sjh120 commented Dec 15, 2023 • edited by Wh1isper Loading

Description

Motivation and Context

How has this been tested?

Types of changes

Checklist:

sweep-ai bot commented Dec 15, 2023

Apply Sweep Rules to your PR?

Wh1isper left a comment • edited Loading

Choose a reason for hiding this comment

MooooCat commented Dec 17, 2023

sjh120 commented Dec 17, 2023

Wh1isper left a comment

Choose a reason for hiding this comment

sjh120 commented Dec 15, 2023 •

edited by Wh1isper

Loading

Wh1isper left a comment •

edited

Loading