-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Base Class of Metric #60
Conversation
for more information, see https://pre-commit.ci
Apply Sweep Rules to your PR?
|
Metric isn't the focus at the moment, I'm in favour of us being able to put a demo on it first, but it might not look like this. |
When we consider But considering that the generated and raw data are not necessarily csv files and pandas can't handle very large amounts of data, then we will get a restricted metrics class(mostly by performance). Maybe we should separate it to model and data interface. |
Co-authored-by: Zhongsheng Ji <9573586@qq.com>
From an algorithmic perspective, metric can become a standalone module (so as to models). We now need to complete the entire process through adding the metric module. Currently @sjh120 is implementing Jensen–Shannon Divergence(JSD Feature) and adding it to the demo of single-table data generation example, we can suggest him to merge JSD Feature and new demo into this branch. |
Good! It would make sense if this PR could contain working demos. |
This is indeed an important factor and has been ignored (even by other simulation data projects). I have a suggestion, please evaluate if it is suitable. Developers first implement the Maybe the same approach can be used for the our models (Synthesizer). |
Yes. I'm glad to see that there are practices that can be referenced, it's much better than imagining things out of thin air. |
* Feature metric jsd (#66) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * jsd * jsd * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * base更新 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Delete .idea directory --------- Co-authored-by: Jinhang Su <171846802@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: MoooCat <141886018+MooooCat@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Update type hint and comments. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Jinhang Su <171846802@qq.com> Co-authored-by: sjh120 <171846802@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com>
for more information, see https://pre-commit.ci
unnecessary imports are also removed.
for more information, see https://pre-commit.ci
The format of some codes has also been adjusted.
for more information, see https://pre-commit.ci
At present, this PR contains:
I prefer to merge this PR at this stage. |
@all-contributors please add @sjh120 for code |
I've put up a pull request to add @sjh120! 🎉 |
* Update metric base-class * Update column metric base class * Update Metric Base Class * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Feature: Add metric jsd (#66) (#71) * Feature metric jsd (#66) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * jsd * jsd * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * base更新 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Delete .idea directory --------- Co-authored-by: Jinhang Su <171846802@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: MoooCat <141886018+MooooCat@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * Update type hint and comments. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Zhongsheng Ji <9573586@qq.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Jinhang Su <171846802@qq.com> Co-authored-by: sjh120 <171846802@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typo error unnecessary imports are also removed. * Add type hints and comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update input check methods The format of some codes has also been adjusted. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> Co-authored-by: Jinhang Su <171846802@qq.com>
Description
Updated several files in the
sdgx/metric/
directoryMotivation and Context
Update the metric base class used to evaluate the quality of synthetic data
How has this been tested?
After the specific metric is implemented, that metric will be integrated into the
test/
directory and tested using pytest.Types of changes
Checklist: