Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stable-baselines-tf2 to project list page. #986

Merged
merged 5 commits into from
Aug 26, 2020
Merged

Add stable-baselines-tf2 to project list page. #986

merged 5 commits into from
Aug 26, 2020

Conversation

sophiagu
Copy link

@sophiagu sophiagu commented Aug 24, 2020

Description

closes #984

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have ensured pytest and pytype both pass (by running make pytest and make type).

@Miffyli Miffyli added the PR template not filled Please fill the pull request template label Aug 24, 2020
@Miffyli
Copy link
Collaborator

Miffyli commented Aug 24, 2020

Please fill in the checklist (e.g. update changelog and include username).

@sophiagu
Copy link
Author

sophiagu commented Aug 24, 2020

The latest release date in changelog is 2020-08-05. Should I add changes under this release date or create a new release date?

@Miffyli
Copy link
Collaborator

Miffyli commented Aug 24, 2020

@araffin Could you answer the above?

@sophiagu
Copy link
Author

sophiagu commented Aug 24, 2020

There is a unit test failure which seems to be irrelevant to my changes: https://travis-ci.com/github/hill-a/stable-baselines/jobs/377081203

@araffin
Copy link
Collaborator

araffin commented Aug 25, 2020

The latest release date in changelog is 2020-08-05. Should I add changes under this release date or create a new release date?

I added a new section for it ;)

@sophiagu
Copy link
Author

pending review?

@Miffyli
Copy link
Collaborator

Miffyli commented Aug 26, 2020

Could you add your alias to the changelog as instructed in the contributor's guide. After that this seems ready for merging :)

Edit: I added them quick and will merge after checks pass. Cheers for the PR!

@sophiagu
Copy link
Author

Thx!!

@Miffyli Miffyli merged commit 3840ddf into hill-a:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR template not filled Please fill the pull request template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I added TF2.x support for stable-baselines
3 participants