Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added TF2.x support for stable-baselines #984

Closed
sophiagu opened this issue Aug 23, 2020 · 6 comments · Fixed by #986
Closed

I added TF2.x support for stable-baselines #984

sophiagu opened this issue Aug 23, 2020 · 6 comments · Fixed by #986
Labels
documentation Documentation should be updated

Comments

@sophiagu
Copy link

sophiagu commented Aug 23, 2020

This is not really an issue but I'd like to let you know that I created a repo for supporting stable-baselines in TF2.x with minimum amount of changes: https://github.com/sophiagu/stable-baselines-tf2
I've tested that repo both on a local machine and in a third party environment.

Hope this will be of help to other people who are using TF2 and Stable Baselines!

@araffin araffin added the documentation Documentation should be updated label Aug 23, 2020
@araffin
Copy link
Collaborator

araffin commented Aug 24, 2020

Hello,

Thank you for doing that =)
We would appreciate a PR that add your repo to the project page ;)

We also had an experimental tf2 version here: https://github.com/Stable-Baselines-Team/stable-baselines-tf2/
(working but far from complete).

@sophiagu
Copy link
Author

np! I hope that helps other people.

Since I haven't been using GitHub extensively, idk how to add my repo to the project page? But if someone knows how to do that, I can add that person as a collaborator to my repo. Or if it's something simple that I can do on my own, I'd appreciate some steps that I can follow.

@Miffyli
Copy link
Collaborator

Miffyli commented Aug 24, 2020

@sophiagu

The project page lists projects that use or are closely related to stable-baselines. @araffin suggests that you make a pull-request to add your project on that list. You can do that by making a fork of stable-baselines, creating a new branch, updating the file and submitting the PR (plenty of info on that online). Alternatively you can simply edit file here on Github and it does all the magic for you.

@sophiagu
Copy link
Author

Thx! I created a update request to the project page: master...sophiagu:patch-1

@Miffyli
Copy link
Collaborator

Miffyli commented Aug 24, 2020

That's not a PR just yet. See e.g. this doc.

@deetungsten
Copy link

deetungsten commented Nov 29, 2020

I created a fork of the original and merged sophiagu's changes so you can install it via pip (https://github.com/deetungsten/stable-baselines) to make life easier when installing it (such as google colab). @sophiagu Thank you so much for making the stablebaseline-tf2! I wanted to see what the performance will be on the new Apple M1 CPU and your work makes it a lot easier (especially since the accelerated version is for r2.4rc0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation should be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants