CompressionType and useIdiomaticEndpoints for Protobuf and Avro #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@franciscodr FYI |
fedefernandez
force-pushed
the
ff/idiomatic
branch
from
83505b1
to
c2f6324
Compare
AlvaroCaste
reviewed
Jun 30, 2019
| @@ -136,6 +136,13 @@ object print { | |||
| case Identity => Right(Identity) | |||
| }) | |||
|
|
|||
| def idiomaticEndpoints: Printer[IdiomaticEndpoints] = | |||
| Printer { | |||
| case IdiomaticEndpoints(Some(pkg), true) => ", namespace = Some(\"" + pkg + "\"), methodNameStyle = Capitalize" | |||
There was a problem hiding this comment.
out of curiosity: is there no "default" Printer for Some or Option?
There was a problem hiding this comment.
@AlvaroCaste I think I don't understand you, sorry. Could you please rephrase it?
There was a problem hiding this comment.
Oh, you mean there is no case for Some + false? Fixed!
There was a problem hiding this comment.
no, sorry, I got it wrong. I thought you were matching an Option and then I wondered if there would already be a Printer for it in order not to rewrite "Some(\"" + pkg + "\") (this happens when I've just skimmed it 😅 )
fedefernandez
force-pushed
the
ff/idiomatic
branch
from
f222cbf
to
6beba09
Compare
fedefernandez
force-pushed
the
ff/idiomatic
branch
from
6beba09
to
1c87924
Compare
fedefernandez
changed the title
|
Ready for review |
BeniVF
pushed a commit
that referenced
this pull request
Jul 24, 2019
* Allows specifying idiomatic endpoints * Allows sending the compression type and makes the test a prop * Removes the print stack trace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #85