Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The proto and avro printers need to receive a new param for setting the idiomatic gRPC to true #85

Closed
fedefernandez opened this issue Apr 24, 2019 · 2 comments
Assignees

Comments

@fedefernandez
Copy link
Contributor

Relates to higherkindness/mu-scala#599

We need a way for indicating to the printers that the generated @service annotation should be populated with the namespace and methodNameStyle params.

Ideally, it should be a flag called something like useIdiomaticRPC that when true it'll put set the namespace equal to Some($package) and methodNameStyle to Capitalize. When false, it can omit those params.

After a talk with @juanpedromoreno, we thought the printer could receive some kind of metadata object with this flag and potentially others.

@pepegar
Copy link
Member

pepegar commented Apr 24, 2019 via email

@fedefernandez
Copy link
Contributor Author

This was addressed at #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants