Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update authors #694

Closed
rgieseke opened this issue Sep 7, 2018 · 2 comments · Fixed by #697
Closed

Update authors #694

rgieseke opened this issue Sep 7, 2018 · 2 comments · Fixed by #697

Comments

@rgieseke
Copy link

rgieseke commented Sep 7, 2018

Trying to understand the new cool Pandas feature i spotted this:

    # I'm happy with both of these as long as Andrew and Zebedee are added on
    # but need to check with Pint Authors...

https://github.com/hgrecco/pint/blob/master/pint/pandas_interface/pint_array.py#L6

This should probably be removed and @znicholls and @andrewgsavage be added to AUTHORS?
@znicholls
Copy link
Contributor

oops yes should have taken that out, will be fixed as part of resolving #693

@hgrecco
Copy link
Owner

hgrecco commented Sep 10, 2018

yes please issue a PR. with both changes.

@znicholls znicholls mentioned this issue Sep 10, 2018
Merged
bors bot added a commit that referenced this issue Sep 25, 2018
@bors @znicholls @andrewgsavage
Merge #697
9283545 
697: Update with pandas interface authors r=hgrecco a=znicholls

closes #694 

@andrewgsavage can you add your email to this (you should be able to push directly to this branch)

Co-authored-by: Zebedee Nicholls <zebedee.nicholls@climate-energy-college.org>
Co-authored-by: andrewgsavage <andrewgsavage@gmail.com>
bors bot added a commit that referenced this issue Oct 1, 2018
@bors @znicholls @andrewgsavage
Merge #697
57206da 
697: Update with pandas interface authors r=hgrecco a=znicholls

closes #694 

@andrewgsavage can you add your email to this (you should be able to push directly to this branch)

Co-authored-by: Zebedee Nicholls <zebedee.nicholls@climate-energy-college.org>
Co-authored-by: andrewgsavage <andrewgsavage@gmail.com>
@bors bors bot closed this as completed in #697 Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update with pandas interface authors znicholls/pint
3 participants
@rgieseke @hgrecco @znicholls