Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.14.0 #49

Merged
merged 19 commits into from
May 7, 2023
Merged

Version 0.14.0 #49

merged 19 commits into from
May 7, 2023

Conversation

hbldh
Copy link
Owner

@hbldh hbldh commented May 5, 2023

Solves

Includes:

Now bundles the Test certificate with the actual code so that test will work due to

  1. Captcha prevents fetching of cert as before
  2. openssh seems to fail to break p12 into pem files, so pem file were included as well.

@hbldh hbldh self-assigned this May 5, 2023
The BankID pages now returns a captcha instead of the actual certificate when fetching with requests. The actual cert is now bundled instead of fetched each time.
@cthart
Copy link
Contributor

cthart commented May 5, 2023

Works for me:

(pybankid) colin@bilby:~/git/pybankid/tests$ pytest 
======================================================== test session starts =========================================================
platform linux -- Python 3.8.10, pytest-7.3.1, pluggy-1.0.0
rootdir: /home/colin/git/pybankid
collected 26 items                                                                                                                   

test_certutils.py .                                                                                                            [  3%]
test_exceptions.py ................                                                                                            [ 65%]
test_jsonclient.py .........                                                                                                   [100%]

========================================================== warnings summary ==========================================================
../../../venv/pybankid/lib/python3.8/site-packages/pkg_resources/__init__.py:121
  /home/colin/venv/pybankid/lib/python3.8/site-packages/pkg_resources/__init__.py:121: DeprecationWarning: pkg_resources is deprecated as an API
    warnings.warn("pkg_resources is deprecated as an API", DeprecationWarning)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=================================================== 26 passed, 1 warning in 2.49s ====================================================

The PIP packages I have installed for the above tests:

(pybankid) colin@bilby:~/git/pybankid/tests$ pip freeze
certifi==2022.12.7
charset-normalizer==3.1.0
exceptiongroup==1.1.1
idna==3.4
iniconfig==2.0.0
packaging==23.1
pkg_resources==0.0.0
pluggy==1.0.0
pybankid==0.13.1
pytest==7.3.1
requests==2.30.0
six==1.16.0
tomli==2.0.1
urllib3==2.0.2

NB The version of PyBankID is with the patch I submitted!

As mentioned above, I have run this and logged in successfully against both test and production BankID servers.

All the tests on GitHub are failing due to some configuration errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants