Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #48

Merged
merged 1 commit into from
May 5, 2023
Merged

Update __init__.py #48

merged 1 commit into from
May 5, 2023

Conversation

cthart
Copy link
Contributor

@cthart cthart commented May 4, 2023

Fix breakage with urllib 2.0.x proposed for issue #47
See urllib3/urllib3#3015 for background information.
This code works for me with test and production certificates.

Fix breakage with urllib 2.0.x
@hbldh
Copy link
Owner

hbldh commented May 5, 2023

Hm, I read about that. Is it not sufficient to pin your urllib3 version below 2 in your application?

@hbldh
Copy link
Owner

hbldh commented May 5, 2023

Should have read better before answering. If this alleviates your problems then I feel confident that it will be enough.

@hbldh hbldh changed the base branch from master to develop May 5, 2023 14:34
@hbldh hbldh self-assigned this May 5, 2023
@hbldh hbldh added the bug label May 5, 2023
@hbldh hbldh merged commit 92ee2a8 into hbldh:develop May 5, 2023
@hbldh hbldh mentioned this pull request May 5, 2023
hbldh added a commit that referenced this pull request May 7, 2023
- Merge of Update README.rst #41
- Merge of Update __init__.py #48
- Merge of Fixes for test certificate download and handling #50

Now bundles the Test certificate with the actual code so that test will work due to

- Captcha prevents fetching of cert as before
- openssh seems to fail to break p12 into pem files, so pem file were included as well.

`certutils` needs to be examined in the near future.


* Update README.rst

Corrected typo in examples

* Update __init__.py

Fix breakage with urllib 2.0.x

* Github Action fixes

* Version bump

* Bump reqs for example

* Bundle the BankID Test certificate

The BankID pages now returns a captcha instead of the actual certificate when fetching with requests. The actual cert is now bundled instead of fetched each time.

* Failure detection in openssl test cert conversion

* Add possibility to provide p12 test cert through existing file

* Bundle the BankID Test certificate in pem format

Bundle pem formats as well.

* Python 2.7 compat. fix

* Rmoving certutils test for the time being

* Remove Python 2.7 support

* Remove six dependency

---------

Co-authored-by: Simon Olofsson <36161882+dotchetter@users.noreply.github.com>
Co-authored-by: Colin 't Hart <colinthart@gmail.com>
Co-authored-by: Stefan Berg <sfb@consultron.com>
@hbldh
Copy link
Owner

hbldh commented May 7, 2023

@cthart This is now released to PyPI in version 0.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants