NodeDestroyResource needs to be referencable #23822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sdkv1
apparentlymart
approved these changes
Jan 9, 2020
|
Looks like those "other optional interface checks" include targeting. I'll look into what's happening there. |
jbardin
force-pushed
the
jbardin/destroy-resource-deps
branch
from
a2cbd40
to
5fabb2a
Compare
|
Being a |
The change in #23696 removed the NodeAbstractResource methods from the NodeDestroyResource type, in order to prevent other resource behaviors, like requesting a provider. While this node type is not directly referenced, it was implicitly ordered against the module cleanup by virtue of being a resource node. Since there's no good entry point to test this ordering at the moment,
jbardin
force-pushed
the
jbardin/destroy-resource-deps
branch
from
5fabb2a
to
a6cdfad
Compare
While the NodeDestroyResource type should not be a GraphNodeProviderConsumer, we're going to avoid uncovering more hidden behavior by explicitly skipping provider creation and connections in the provider transformers. This should be removed when more in-depth testing can be done during a major release cycle.
jbardin
force-pushed
the
jbardin/destroy-resource-deps
branch
from
353a4c5
to
4aa8a1c
Compare
|
Rather than risk discovering any more hidden behaviors associated with this type, add a |
apparentlymart
approved these changes
Jan 10, 2020
This was referenced Jan 14, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #23696 removed the NodeAbstractResource methods from the
NodeDestroyResource type, in order to prevent other resource behaviors,
like requesting a provider.
While this node type is not directly referenced, it was implicitly
ordered against the module cleanup by virtue of being a resource node.
The ReferenceTransformer uses the GraphNodeReferenceable and
GraphNodeSubPath interfaces to add nodes to the reference map, so we
need to re-add the relevant methods.
Since there's no good entry point to test this ordering at the moment,
add static checks for the interfaces, and document where these
interfaces are required.
Fixes #23821